]> git.proxmox.com Git - mirror_qemu.git/commit
linux-user: Don't use alloca() for epoll_wait's epoll event array
authorPeter Maydell <peter.maydell@linaro.org>
Mon, 18 Jul 2016 14:36:00 +0000 (15:36 +0100)
committerRiku Voipio <riku.voipio@linaro.org>
Fri, 21 Oct 2016 12:19:41 +0000 (15:19 +0300)
commit04c95f4da7f657a0bef17d115d0a5ca2ac0e2d22
tree736a7cadc4ba8bec87fa81acc274ceeb152df7c4
parent434f286bbc1570b204ac2a450d92890578594773
linux-user: Don't use alloca() for epoll_wait's epoll event array

The epoll event array which epoll_wait() allocates has a size
determined by the guest which could potentially be quite large.
Use g_try_new() rather than alloca() so that we can fail more
cleanly if the guest hands us an oversize value. (ENOMEM is
not a documented return value for epoll_wait() but in practice
some kernel configurations can return it -- see for instance
sys_oabi_epoll_wait() on ARM.)

This rearrangement includes fixing a bug where we were
incorrectly passing a negative length to unlock_user() in
the error-exit codepath.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
linux-user/syscall.c