]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/sched: act_mirred: better wording on protection against excessive stack growth
authorDavide Caratti <dcaratti@redhat.com>
Fri, 20 Jan 2023 17:01:39 +0000 (18:01 +0100)
committerRoxana Nicolescu <roxana.nicolescu@canonical.com>
Wed, 17 May 2023 11:33:36 +0000 (13:33 +0200)
commit050d54052ae9e8bb85457d18056889edf7c7fe14
tree293e4cf0408ffe23d58dccf196b471127d611cdb
parent8cc6cf45f7762aed6a12a420c4195132ddfbdb30
net/sched: act_mirred: better wording on protection against excessive stack growth

BugLink: https://bugs.launchpad.net/bugs/2016877
[ Upstream commit 78dcdffe0418ac8f3f057f26fe71ccf4d8ed851f ]

with commit e2ca070f89ec ("net: sched: protect against stack overflow in
TC act_mirred"), act_mirred protected itself against excessive stack growth
using per_cpu counter of nested calls to tcf_mirred_act(), and capping it
to MIRRED_RECURSION_LIMIT. However, such protection does not detect
recursion/loops in case the packet is enqueued to the backlog (for example,
when the mirred target device has RPS or skb timestamping enabled). Change
the wording from "recursion" to "nesting" to make it more clear to readers.

CC: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Stable-dep-of: ca22da2fbd69 ("act_mirred: use the backlog for nested calls to mirred ingress")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
net/sched/act_mirred.c