]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
mtd: spi-nor: stm32-quadspi: Fix uninitialized error return code
authorGeert Uytterhoeven <geert@linux-m68k.org>
Thu, 26 Oct 2017 15:12:33 +0000 (17:12 +0200)
committerCyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Sun, 29 Oct 2017 17:30:13 +0000 (18:30 +0100)
commit05521bd3d117704a1458eb4d0c3ae821858658f2
treeab4910aa18808566e5e29cdc9f228e4df3a1dc7c
parentb8cc0012917d9a1ab1497a38c8675ecc4d9d94f2
mtd: spi-nor: stm32-quadspi: Fix uninitialized error return code

With gcc 4.1.2:

    drivers/mtd/spi-nor/stm32-quadspi.c: In function ‘stm32_qspi_tx_poll’:
    drivers/mtd/spi-nor/stm32-quadspi.c:230: warning: ‘ret’ may be used uninitialized in this function

Indeed, if stm32_qspi_cmd.len is zero, ret will be uninitialized.
This length is passed from outside the driver using the
spi_nor.{read,write}{,_reg}() callbacks.

Several functions in drivers/mtd/spi-nor/spi-nor.c (e.g. write_enable(),
write_disable(), and erase_chip()) call spi_nor.write_reg() with a zero
length.

Fix this by returning an explicit zero on success.

Fixes: 0d43d7ab277a048c ("mtd: spi-nor: add driver for STM32 quad spi flash controller")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Ludovic Barre <ludovic.barre@st.com>
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
drivers/mtd/spi-nor/stm32-quadspi.c