]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ibmvnic: drop bad optimization in reuse_rx_pools()
authorSukadev Bhattiprolu <sukadev@linux.ibm.com>
Wed, 1 Dec 2021 05:48:35 +0000 (21:48 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Dec 2021 12:09:19 +0000 (12:09 +0000)
commit0584f4949609c0391ca98edf180c8ab7386c483a
treeecb1df0f3f6f5330493a759ef1cdcf14dd667261
parent789b6cc2a5f9123b9c549b886fdc47c865cfe0ba
ibmvnic: drop bad optimization in reuse_rx_pools()

When trying to decide whether or not reuse existing rx/tx pools
we tried to allow a range of values for the pool parameters rather
than exact matches. This was intended to reuse the resources for
instance when switching between two VIO servers with different
default parameters.

But this optimization is incomplete and breaks when we try to
change the number of queues for instance. The optimization needs
to be updated, so drop it for now and simplify the code.

Fixes: 489de956e7a2 ("ibmvnic: Reuse rx pools when possible")
Reported-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Reviewed-by: Rick Lindsley <ricklind@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c