]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
mptcp: plug subflow context memory leak
authorPaolo Abeni <pabeni@redhat.com>
Wed, 9 Dec 2020 11:03:30 +0000 (12:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Dec 2020 03:31:58 +0000 (19:31 -0800)
commit0597d0f8e030d1a5e64708b0f3233209a8b5d39e
treee7f5a62be4747f8cf38f273d1656303812f79750
parent5b950ff4331ddda6421b21a779ec23127e8e3eb8
mptcp: plug subflow context memory leak

When a MPTCP listener socket is closed with unaccepted
children pending, the ULP release callback will be invoked,
but nobody will call into __mptcp_close_ssk() on the
corresponding subflow.

As a consequence, at ULP release time, the 'disposable' flag
will be cleared and the subflow context memory will be leaked.

This change addresses the issue always freeing the context if
the subflow is still in the accept queue at ULP release time.

Additionally, this fixes an incorrect code reference in the
related comment.

Note: this fix leverages the changes introduced by the previous
commit.

Fixes: e16163b6e2b7 ("mptcp: refactor shutdown and close")
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/subflow.c