]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: bebob: fix to detect configured source of sampling clock for Focusrite Saffire...
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sat, 2 Nov 2019 15:09:20 +0000 (00:09 +0900)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 26 Nov 2019 12:16:05 +0000 (13:16 +0100)
commit05bfb5432e2704a84a5a5b8f3f9fd1d1351c847a
tree480356b83421ddf01ef64ada46f45191df3e9761
parent021de0993207fd4f28e7088f1a831bb9cb6c6358
ALSA: bebob: fix to detect configured source of sampling clock for Focusrite Saffire Pro i/o series

BugLink: https://bugs.launchpad.net/bugs/1853519
commit 706ad6746a66546daf96d4e4a95e46faf6cf689a upstream.

For Focusrite Saffire Pro i/o, the lowest 8 bits of register represents
configured source of sampling clock. The next lowest 8 bits represents
whether the configured source is actually detected or not just after
the register is changed for the source.

Current implementation evaluates whole the register to detect configured
source. This results in failure due to the next lowest 8 bits when the
source is connected in advance.

This commit fixes the bug.

Fixes: 25784ec2d034 ("ALSA: bebob: Add support for Focusrite Saffire/SaffirePro series")
Cc: <stable@vger.kernel.org> # v3.16+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20191102150920.20367-1-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
sound/firewire/bebob/bebob_focusrite.c