]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
VSOCK: make af_vsock.ko removable again
authorStefan Hajnoczi <stefanha@redhat.com>
Tue, 17 Apr 2018 06:25:58 +0000 (14:25 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Apr 2018 13:44:30 +0000 (09:44 -0400)
commit05e489b1596f0aa1025a1fa572676631cd9665da
tree20855a057bab049eaefaf19916d4ebf38ba288f8
parent5968a70d7af5f2abbd9d9f9c8e86da51f0a6b16d
VSOCK: make af_vsock.ko removable again

Commit c1eef220c1760762753b602c382127bfccee226d ("vsock: always call
vsock_init_tables()") introduced a module_init() function without a
corresponding module_exit() function.

Modules with an init function can only be removed if they also have an
exit function.  Therefore the vsock module was considered "permanent"
and could not be removed.

This patch adds an empty module_exit() function so that "rmmod vsock"
works.  No explicit cleanup is required because:

1. Transports call vsock_core_exit() upon exit and cannot be removed
   while sockets are still alive.
2. vsock_diag.ko does not perform any action that requires cleanup by
   vsock.ko.

Fixes: c1eef220c176 ("vsock: always call vsock_init_tables()")
Reported-by: Xiumei Mu <xmu@redhat.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Jorgen Hansen <jhansen@vmware.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/vmw_vsock/af_vsock.c