]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
Revert "net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register"
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 3 Jan 2022 19:34:52 +0000 (11:34 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 4 Jan 2022 02:59:16 +0000 (18:59 -0800)
commit065e1ae02fbe5f56f4aa118414d45fc30647acd4
tree7bc427a703d8a4b239cf8e4cffc4e32c0663741b
parent95bdba23b5b4aa75fe3e6c84335e638641c707bb
Revert "net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register"

This reverts commit b45396afa4177f2b1ddfeff7185da733fade1dc3 ("net: phy:
fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register")
since it prevents any system that uses a fixed PHY without a GPIO
descriptor from properly working:

[    5.971952] brcm-systemport 9300000.ethernet: failed to register fixed PHY
[    5.978854] brcm-systemport: probe of 9300000.ethernet failed with error -22
[    5.986047] brcm-systemport 9400000.ethernet: failed to register fixed PHY
[    5.992947] brcm-systemport: probe of 9400000.ethernet failed with error -22

Fixes: b45396afa417 ("net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20220103193453.1214961-1-f.fainelli@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/fixed_phy.c