]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
[POWERPC] mpic: Fix use of uninitialized variable
authorStephen Rothwell <sfr@canb.auug.org.au>
Wed, 21 May 2008 06:24:31 +0000 (16:24 +1000)
committerPaul Mackerras <paulus@samba.org>
Fri, 23 May 2008 06:15:37 +0000 (16:15 +1000)
commit06a901c5621f85e07e00ac4816c7ca95620ee74a
tree0f6a0d19d889e4209a41889ed868bc8af2a581eb
parentd1e8d50d5a4bc7e40b119bf513804188ce2933d0
[POWERPC] mpic: Fix use of uninitialized variable

Compiling ppc64_defconfig with gcc 4.3 gives thes warnings:

arch/powerpc/sysdev/mpic.c: In function 'mpic_irq_get_priority':
arch/powerpc/sysdev/mpic.c:1351: warning: 'is_ipi' may be used uninitialized in this function
arch/powerpc/sysdev/mpic.c: In function 'mpic_irq_set_priority':
arch/powerpc/sysdev/mpic.c:1328: warning: 'is_ipi' may be used uninitialized in this function

It turns out that in the cases where is_ipi is uninitialized, another
variable (mpic) will be NULL and it is dereferenced.  Protect against
this by returning if mpic is NULL in mpic_irq_set_priority, and removing
mpic_irq_get_priority completely as it has no in tree callers.

This has the nice side effect of making the warning go away.

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/sysdev/mpic.c
include/asm-powerpc/mpic.h