]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
scsi: hisi_sas: fix probe ordering problem
authorXiang Chen <chenxiang66@hisilicon.com>
Fri, 20 Jan 2017 12:45:23 +0000 (20:45 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 21 Jan 2017 00:10:42 +0000 (19:10 -0500)
commit0757f041b171d19cab9b6dac186a588ba0260055
tree8e8c7d5f58317a90546b31513aa0474f182cbe56
parent297d73023ac559ea0cb4f1638fc8563b8c763c1e
scsi: hisi_sas: fix probe ordering problem

There is a potential probe issue in how we trigger the hw initialisation.
Although we use 1s timer to delay hw initialisation, there is still a
potential that sas_register_ha() is not be finished before we start
the PHY init from hw->hw_init().
To avoid this issue, initialise the hw after sas_register_ha() in the
same probe context.
Note: it is not necessary to use 1s timer now (modified v2 hw only).

Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_main.c
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c