]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
module: drop version-attribute alignment
authorJohan Hovold <johan@kernel.org>
Mon, 23 Nov 2020 10:23:14 +0000 (11:23 +0100)
committerJessica Yu <jeyu@kernel.org>
Wed, 25 Nov 2020 14:44:36 +0000 (15:44 +0100)
commit0801a0073f86e020987acbbd96b50f9c85d79de8
tree77e4c9384c7c28005dd0a76859248a83c65bb47d
parent24b9f0d22081455b6fd739c8365958c207a69973
module: drop version-attribute alignment

Commit 98562ad8cb03 ("module: explicitly align module_version_attribute
structure") added an alignment attribute to the struct
module_version_attribute type in order to fix an alignment issue on m68k
where the structure is 2-byte aligned while MODULE_VERSION() forced the
__modver section entries to be 4-byte aligned (sizeof(void *)).

This was essentially an alternative fix to the problem addressed by
b4bc842802db ("module: deal with alignment issues in built-in module
versions") which used the array-of-pointer trick to prevent gcc from
increasing alignment of the version attribute entries. And with the
pointer indirection in place there's no need to increase the alignment
of the type.

Link: https://lore.kernel.org/lkml/20201103175711.10731-1-johan@kernel.org
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
include/linux/module.h