]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
null_blk: unalign call_single_data
authorJens Axboe <axboe@kernel.dk>
Wed, 20 Dec 2017 20:14:42 +0000 (13:14 -0700)
committerJens Axboe <axboe@kernel.dk>
Wed, 20 Dec 2017 20:16:33 +0000 (13:16 -0700)
commit0864fe09ab90ab32b7d21fe3cd72df5b5af8492e
tree0eccf5d3eb91f7eb9432e7c70b03dc33184b7b58
parent4ccafe032005e9b96acbef2e389a4de5b1254add
null_blk: unalign call_single_data

Commit 966a967116e6 randomly added alignment to this structure, but
it's actually detrimental to performance of null_blk. Test case:

Running on both the home and remote node shows a ~5% degradation
in performance.

While in there, move blk_status_t to the hole after the integer tag
in the nullb_cmd structure. After this patch, we shrink the size
from 192 to 152 bytes.

Fixes: 966a967116e69 ("smp: Avoid using two cache lines for struct call_single_data")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/null_blk.c