]> git.proxmox.com Git - mirror_qemu.git/commit
scripts: use build_ prefix for string not piped through cgen()
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Thu, 1 Jun 2017 12:41:41 +0000 (16:41 +0400)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 12 Jul 2017 15:51:54 +0000 (17:51 +0200)
commit086ee7a6200fa5ad795b12110b5b3d5a93dcac3e
tree0de1897c3b5fa65572d1d7972b7ab8477bbc16e6
parent8a4613a0ab4b6e9271e64aaa88f588ed1b749eb4
scripts: use build_ prefix for string not piped through cgen()

The gen_ prefix is awkward.  Generated C should go through cgen()
exactly once (see commit 1f9a7a1).  The common way to get this wrong is
passing a foo=gen_foo() keyword argument to mcgen().  I'd like us to
adopt a naming convention where gen_ means "something that's been piped
through cgen(), and thus must not be passed to cgen() or mcgen()".
Requires renaming gen_params(), gen_marshal_proto() and
gen_event_send_proto().

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20170601124143.10915-1-marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
scripts/qapi-commands.py
scripts/qapi-event.py
scripts/qapi.py