]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
xprtrdma: Squelch kbuild sparse complaint
authorChuck Lever <chuck.lever@oracle.com>
Sat, 11 Mar 2017 20:52:47 +0000 (15:52 -0500)
committerTim Gardner <tim.gardner@canonical.com>
Tue, 28 Mar 2017 20:17:54 +0000 (14:17 -0600)
commit087e7b3385266813fcabf199e2bd0cf8867f4e91
treec46add422be2db23d9f5d04becb82ca1e118f24e
parent2f177c45420e23394ecb54c1267da146b833699c
xprtrdma: Squelch kbuild sparse complaint

BugLink: http://bugs.launchpad.net/bugs/1676429
commit eed50879d64ab1b9f76445dbab822e43a098b309 upstream.

New complaint from kbuild for 4.9.y:

net/sunrpc/xprtrdma/verbs.c:489:19: sparse: incompatible types in
    comparison expression (different type sizes)

verbs.c:
489 max_sge = min(ia->ri_device->attrs.max_sge, RPCRDMA_MAX_SEND_SGES);

I can't reproduce this running sparse here. Likewise, "make W=1
net/sunrpc/xprtrdma/verbs.o" never indicated any issue.

A little poking suggests that because the range of its values is
small, gcc can make the actual width of RPCRDMA_MAX_SEND_SGES
smaller than the width of an unsigned integer.

Fixes: 16f906d66cd7 ("xprtrdma: Reduce required number of send SGEs")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
net/sunrpc/xprtrdma/verbs.c