]> git.proxmox.com Git - mirror_qemu.git/commit
pci-host: Consistently set cannot_instantiate_with_device_add_yet
authorMarkus Armbruster <armbru@redhat.com>
Thu, 28 Nov 2013 16:26:58 +0000 (17:26 +0100)
committerAndreas Färber <afaerber@suse.de>
Sun, 22 Dec 2013 23:27:23 +0000 (00:27 +0100)
commit08c58f92f66dcf0a9097c3a6a65bcc4ffd71268f
tree25c48490e35cfaeae55d5f9370f479a4a56271a0
parentf37a4374bae20ca678b808b5ee32319e943b1b4b
pci-host: Consistently set cannot_instantiate_with_device_add_yet

Many PCI host bridges consist of a sysbus device and a PCI device.
You need both for the thing to work.  Arguably, these bridges should
be modelled as a single, composite devices instead of pairs of
seemingly independent devices you can only use together, but we're not
there, yet.

Since the sysbus part can't be instantiated with device_add, yet,
permitting it with the PCI part is useless.  We shouldn't offer
useless options to the user, so let's set
cannot_instantiate_with_device_add_yet for them.

It's already set for Bonito, Grackle, i440FX and Raven.  Document why.

Set it for the others: dec-21154, e500-host-bridge, gt64120_pci, mch,
pbm-pci, ppc4xx-host-bridge, sh_pci_host, u3-agp, uni-north-agp,
uni-north-internal-pci, uni-north-pci, and versatile_pci_host.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
13 files changed:
hw/mips/gt64xxx_pci.c
hw/pci-bridge/dec.c
hw/pci-host/apb.c
hw/pci-host/bonito.c
hw/pci-host/grackle.c
hw/pci-host/piix.c
hw/pci-host/ppce500.c
hw/pci-host/prep.c
hw/pci-host/q35.c
hw/pci-host/uninorth.c
hw/pci-host/versatile.c
hw/ppc/ppc4xx_pci.c
hw/sh4/sh_pci.c