]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
media: atomisp: reduce the risk of a race condition
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Sun, 10 May 2020 14:06:53 +0000 (16:06 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 20 May 2020 12:51:28 +0000 (14:51 +0200)
commit09d87466655d00526cf818b3f3b267884c591702
tree8d64a7542be78e8b436c1583a9b732ad2c8f914f
parentd03f2e248c416cd07105ad25fe1809c14fbb47c1
media: atomisp: reduce the risk of a race condition

This driver is really on bad shape. One of the problems
is that, as soon as the I2C transfers start to happen, it
timeouts detecting a camera:

ov2680 i2c-OVTI2680:00: ov2680_probe: ACPI detected it on bus ID=CAM1, HID=OVTI2680
atomisp-isp2 0000:00:03.0: no camera attached or fail to detect
ov2680 i2c-OVTI2680:00: gmin: initializing atomisp module subdev data using PMIC regulator
...

The right fix here would be to use defer probe, but driver is
still on too bad shape.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_v4l2.c