]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 19 Jan 2022 01:04:32 +0000 (09:04 +0800)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 10 Feb 2022 14:31:37 +0000 (15:31 +0100)
commit0a2c53d04dd8e58b22d0aae850b6c4bcc758a9ab
tree915fbcaf8f43091a8e7008ba57dc2e8ea80cb0d7
parent0ca0f1fb7353a9a6f4458d04c75b3ef258ba41d0
gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()

BugLink: https://bugs.launchpad.net/bugs/1960516
commit 9f51ce0b9e73f83bab2442b36d5e247a81bd3401 upstream.

The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'irqn', so making 'irqn' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression
compared with zero: mpc8xxx_gc -> irqn < 0

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 0b39536cc699 ("gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/gpio/gpio-mpc8xxx.c