]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ASoC: rt5514: Avoid relying on uninitialized "val" value
authorDouglas Anderson <dianders@chromium.org>
Fri, 14 Apr 2017 16:40:31 +0000 (09:40 -0700)
committerMark Brown <broonie@kernel.org>
Fri, 14 Apr 2017 17:11:37 +0000 (18:11 +0100)
commit0a78b248c3324fbbba49f74e2c93e0f436583788
tree90310071ac5889c401d7cf5b922aa44ba8f029c0
parentd0c02e14e48be94dd312ff6edffab9f9e6acd480
ASoC: rt5514: Avoid relying on uninitialized "val" value

In rt5514_i2c_probe() if the regmap_read(RT5514_VENDOR_ID2) fails then
"val" may be left as uninitialized.  Current code relies on "val" not
being RT5514_DEVICE_ID, but that's potentially unsafe.

Let's check for errors from regmap_read() and also explicitly init the
value do we're not passing a possibly uninitialized int to printk.

Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5514.c