]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
fbdev: da8xx-fb: Drop unnecessary static
authorJulia Lawall <Julia.Lawall@lip6.fr>
Tue, 1 Aug 2017 15:20:39 +0000 (17:20 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 1 Aug 2017 15:20:39 +0000 (17:20 +0200)
commit0ae6ee006cec19d9f53f3d042de173f4b70649df
tree59547677076960e5dafe788879e0e78f4320c4e7
parenta86d8d67989d1b89ff396be2c0f7f8be2524d38a
fbdev: da8xx-fb: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before
any possible use.  Thus, the static has no benefit.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@bad exists@
position p;
identifier x;
type T;
@@
static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@
-static
 T x@p;
 ... when != x
     when strict
?x = e;
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Kees Cook <keescook@chromium.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/da8xx-fb.c