]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
gianfar: Reduce logging noise seen due to phy polling if link is down
authorGuenter Roeck <linux@roeck-us.net>
Mon, 2 Mar 2015 20:03:27 +0000 (12:03 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Mar 2015 19:37:30 +0000 (14:37 -0500)
commit0ae93b2cccbcc060899800a6bac7905a7d754448
tree8cfafaa9dacc92bcdaf5ba2640a1a63a7d1a54ee
parentc77c761fa40e0ebdacb728b0310191ef8dc6902b
gianfar: Reduce logging noise seen due to phy polling if link is down

Commit 6ce29b0e2a04 ("gianfar: Avoid unnecessary reg accesses in adjust_link()")
eliminates unnecessary calls to adjust_link for phy devices which don't support
interrupts and need polling. As part of that work, the 'new_state' local flag,
which was used to reduce logging noise on the console, was eliminated.

Unfortunately, that means that a 'Link is Down' log message will now be
issued continuously if a link is configured as UP, the link state is down,
and the associated phy requires polling. This occurs because priv->oldduplex
is -1 in this case, which always differs from phydev->duplex. In addition,
phydev->speed may also differ from priv->oldspeed.  gfar_update_link_state()
is therefore called each time a phy is polled, even if the link state did not
change.

Cc: Claudiu Manoil <claudiu.manoil@freescale.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Claudiu Manoil <claudiu.manoil@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/gianfar.c