]> git.proxmox.com Git - mirror_qemu.git/commit
virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug
authorPaolo Bonzini <pbonzini@redhat.com>
Tue, 15 Oct 2013 14:47:16 +0000 (16:47 +0200)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 9 Dec 2013 20:46:48 +0000 (21:46 +0100)
commit0b81c1ef5c677c2a07be5f8bf0dfe2c62ef52115
treed40bad794a58e7caf4fe8b149ab3d6a0812006fc
parent7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e
virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug

Similar to the PCI bug that prompted these patches, virtio-ccw will
segfault after the reworking of hotplug/hot-unplug.  Prepare for
this by moving virtio_ccw_stop_ioeventfd to before the freeing
of the proxy device.

A better place for this could be the device_unplugged callback
for the virtio-ccw bus.  However, we do not yet have a callback
that works: this patch avoids the problem while leaving the tree
bisectable.

Cc: qemu-stable@nongnu.org
Reported-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Suggested-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Acked-by: Andreas Faerber <afaerber@suse.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/s390x/virtio-ccw.c