]> git.proxmox.com Git - mirror_qemu.git/commit
python/aqmp: rename 'accept()' to 'start_server_and_accept()'
authorJohn Snow <jsnow@redhat.com>
Fri, 25 Feb 2022 20:59:40 +0000 (15:59 -0500)
committerJohn Snow <jsnow@redhat.com>
Mon, 7 Mar 2022 19:36:41 +0000 (14:36 -0500)
commit0ba4e76b23fed77d09be7f56da783ab3f0b2d497
tree734f2cdc04e6616815f62b56d91c37b7d6f06640
parent40196c23939758abc5300e85333e676196e3ba6d
python/aqmp: rename 'accept()' to 'start_server_and_accept()'

Previously, I had a method named "accept()" that under-the-hood calls
bind(2), listen(2) *and* accept(2). I meant this as a simplification and
counterpart to the one-shot "connect()" method.

This is confusing to readers who expect accept() to mean *just*
accept(2). Since I need to split apart the "accept()" method into
multiple methods anyway (one of which strongly resembling accept(2)), it
feels pertinent to rename this method *now*.

Rename this all-in-one method "start_server_and_accept()" instead.

Signed-off-by: John Snow <jsnow@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20220225205948.3693480-3-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
python/qemu/aqmp/legacy.py
python/qemu/aqmp/protocol.py
python/tests/protocol.py