]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
dmaengine: qcom: fix gpi undefined behavior
authorArnd Bergmann <arnd@arndb.de>
Sun, 3 Jan 2021 13:57:29 +0000 (14:57 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 4 Jan 2021 12:38:36 +0000 (18:08 +0530)
commit0bd1bf86ab79555425b9f0b63005e181defe4da6
tree351085ec5a122f4fbde7a4fbc56544f5e4e993c9
parentcc465fa269bc0dc63a1ab7384110e4079fb40421
dmaengine: qcom: fix gpi undefined behavior

gcc points out an incorrect error handling loop:

drivers/dma/qcom/gpi.c: In function 'gpi_ch_init':
drivers/dma/qcom/gpi.c:1254:15: error: iteration 2 invokes undefined behavior [-Werror=aggressive-loop-optimizations]
 1254 |  struct gpii *gpii = gchan->gpii;
      |               ^~~~
drivers/dma/qcom/gpi.c:1951:2: note: within this loop
 1951 |  for (i = i - 1; i >= 0; i++) {
      |  ^~~

Change the loop to correctly walk backwards through the
initialized fields rather than off into the woods.

Fixes: 5d0c3533a19f ("dmaengine: qcom: Add GPI dma driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210103135738.3741123-1-arnd@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/gpi.c