]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
nfp: only clean `sp_indiff` when application firmware is unloaded
authorYinjun Zhang <yinjun.zhang@corigine.com>
Thu, 20 Oct 2022 08:14:11 +0000 (09:14 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 22 Oct 2022 05:43:48 +0000 (22:43 -0700)
commit0bda03623e6b8b9052da5ba0145608941bcc2eb0
treec6c2e2cb51a67029c933c0114c56d288609e68e8
parent0a09f01f11e7c5493ec87a1f9c8824c3fc010751
nfp: only clean `sp_indiff` when application firmware is unloaded

Currently `sp_indiff` is cleaned when driver is removed. This will
cause problem in multi-PF/multi-host case, considering one PF is
removed while another is still in use.

Since `sp_indiff` is the application firmware property, it should
only be cleaned when the firmware is unloaded. Now let management
firmware to clean it when necessary, driver only set it.

Fixes: b1e4f11e426d ("nfp: refine the ABI of getting `sp_indiff` info")
Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20221020081411.80186-1-simon.horman@corigine.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/netronome/nfp/nfp_main.c