]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ARM: omap: fix uninformative vc/i2c configuration error message
authorRussell King <rmk+kernel@arm.linux.org.uk>
Tue, 7 Feb 2012 10:23:43 +0000 (10:23 +0000)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Mon, 13 Feb 2012 10:00:35 +0000 (10:00 +0000)
commit0bf68f53f164e169c2bc77f707338fc595b6ccfc
tree2d9d4c6c3e9dd4873f7ecb6243171cc1029ddeec
parent2d5b4790b1e7cffb8987e535d4969d10b62f3163
ARM: omap: fix uninformative vc/i2c configuration error message

On my OMAP4 platform, I'm getting this error message repeated several
times at boot:

omap_vc_i2c_init: I2C config for all channels must match.
omap_vc_i2c_init: I2C config for all channels must match.

This doesn't help identify what the problem is.  Fix this message to
be more informative:

omap_vc_i2c_init: I2C config for vdd_iva does not match other channels (0).
omap_vc_i2c_init: I2C config for vdd_mpu does not match other channels (0).

This allows us to identify which voltage domains have a problem, and
what the I2C configuration state (a boolean, i2c_high_speed) setting
being used actually is.

From this we find that omap4_core_pmic has i2c_high_speed false, but
omap4_iva_pmic and omap4_mpu_pmic both have it set true.

Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Kevin Hilman <khilman@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mach-omap2/vc.c