]> git.proxmox.com Git - mirror_qemu.git/commit
ppc: make Error **errp const where it is appropriate
authorVladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Thu, 5 Dec 2019 17:46:21 +0000 (20:46 +0300)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 18 Dec 2019 07:43:19 +0000 (08:43 +0100)
commit0c115681a5194a53a4b373c4ff6d8b42ddd23b55
treeebca420651c13ab94613f345dc47cf30c40a9bc3
parent1a639fdf960393d91d96bb938e1c08a5de41fd76
ppc: make Error **errp const where it is appropriate

Mostly, Error ** is for returning error from the function, so the
callee sets it. However kvmppc_hint_smt_possible gets already filled
errp parameter. It doesn't change the pointer itself, only change the
internal state of referenced Error object. So we can make it Error
*const * errp, to stress the behavior. It will also help coccinelle
script (in future) to distinguish such cases from common errp usage.

While there, rename the function to
kvmppc_error_append_smt_possible_hint().

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
Message-Id: <20191205174635.18758-8-vsementsov@virtuozzo.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message replaced]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
hw/ppc/spapr.c
target/ppc/kvm.c
target/ppc/kvm_ppc.h