]> git.proxmox.com Git - mirror_frr.git/commit
zebra: GR code could potentially stop running
authorDonald Sharp <sharpd@nvidia.com>
Fri, 24 Mar 2023 18:29:26 +0000 (14:29 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Wed, 29 Mar 2023 11:48:42 +0000 (07:48 -0400)
commit0c1fd82df66237feb25a8eb8657b5a220ff5575c
tree91e52d443f9f7b9c9780a67e1eaabe254343004b
parent559dbc2ea19f8618e8c8284d28e9f21d939db1bd
zebra: GR code could potentially stop running

When GR is running and attempting to clear up a node
if the node that is currently saved and we are coming
back to happens to be deleted during the time zebra
suspends the GR code due to hitting the node limit
then zebra GR code will just completely stop processing
and potentially leave stale nodes around forever.

Let's just remove this hole and process what we can.
Can you imagine trying to debug this after the fact?

If we remove a node then that counts toward the maximum
to process of ZEBRA_MAX_STALE_ROUTE_COUNT.  This should
prevent any non-processing with a slightly larger cost
of having to look at a few nodes repeatedly

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra/zebra_gr.c
zebra/zserv.c
zebra/zserv.h