]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
ASoC: rsnd: Don't treat master SSI in multi SSI setup as parent
authorMatthias Blankertz <matthias.blankertz@cetitec.com>
Fri, 17 Apr 2020 15:30:16 +0000 (17:30 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 20 Apr 2020 13:16:17 +0000 (14:16 +0100)
commit0c258657ddfe81b4fc0183378d800c97ba0b7cdd
tree6a6df6237fdd0d57acdcf47eca43b33fc55d7d32
parent15a5760cb8b6d5c1ebbf1d2e1f0b77380ab68a82
ASoC: rsnd: Don't treat master SSI in multi SSI setup as parent

The master SSI of a multi-SSI setup was attached both to the
RSND_MOD_SSI slot and the RSND_MOD_SSIP slot of the rsnd_dai_stream.
This is not correct wrt. the meaning of being "parent" in the rest of
the SSI code, where it seems to indicate an SSI that provides clock and
word sync but is not transmitting/receiving audio data.

Not treating the multi-SSI master as parent allows removal of various
special cases to the rsnd_ssi_is_parent conditions introduced in commit
a09fb3f28a60 ("ASoC: rsnd: Fix parent SSI start/stop in multi-SSI mode").
It also fixes the issue that operations performed via rsnd_dai_call()
were performed twice for the master SSI. This caused some "status check
failed" spam when stopping a multi-SSI stream as the driver attempted to
stop the master SSI twice.

Signed-off-by: Matthias Blankertz <matthias.blankertz@cetitec.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/20200417153017.1744454-2-matthias.blankertz@cetitec.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/ssi.c