]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: pcm3168a: cleanup unintuitive mask usage
authorNikita Yushchenko <nikita.yoush@cogentembedded.com>
Tue, 8 Feb 2022 08:42:17 +0000 (11:42 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 14 Feb 2022 12:52:52 +0000 (12:52 +0000)
commit0c483a07e92638aca1f7d42a4986e32c58d29ad2
tree69348522b5517a31edb5341a7b17d159986e4e77
parente7c799e76f070b4ac13498e532574466064ad6a5
ASoC: pcm3168a: cleanup unintuitive mask usage

When checking if the requested parameters are supported, the driver uses
PCM3168A_FMT_DSP_MASK to check for PCM3168A_FMT_DSP_* values.

However, formally not only PCM3168A_FMT_DSP_* values match that
condition, PCM3168A_FMT_I2S_TDM and PCM3168A_FMT_LEFT_J_TDM also do.

The check still gives correct result because those extra values can't
be in 'fmt' at the check location. Still, to make the code less cryptic,
better to compare 'fmt' with PCM3168A_FMT_DSP_* values explicitly.

Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Link: https://lore.kernel.org/r/20220208084220.1289836-2-nikita.yoush@cogentembedded.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/pcm3168a.c