]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
Revert "drm/i915: Skip over MI_NOOP when parsing"
authorJason Ekstrand <jason@jlekstrand.net>
Wed, 14 Jul 2021 19:34:19 +0000 (14:34 -0500)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 16 Jul 2021 19:48:02 +0000 (21:48 +0200)
commit0c6609bb20cf473f48403763aa9a9504ff95fa0f
tree697d9a44506fa432138d7237833c5425ac465614
parentdc194184d0ce1ba7837f91e0af20e95923049d4d
Revert "drm/i915: Skip over MI_NOOP when parsing"

This reverts a6c5e2aea704 ("drm/i915: Skip over MI_NOOP when parsing").
It complicates the batch parsing code a bit and increases indentation
for no reason other than fast-skipping a command that userspace uses
only rarely.  Sure, there may be IGT tests that fill batches with NOOPs
but that's not a case we should optimize for in the kernel.  We should
optimize for code clarity instead.

Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Jon Bloomfield <jon.bloomfield@intel.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210714193419.1459723-6-jason@jlekstrand.net
drivers/gpu/drm/i915/i915_cmd_parser.c