]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
gpio: idt3243x: Fix an ignored error return from platform_get_irq()
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 19 Jan 2022 01:04:31 +0000 (09:04 +0800)
committerPaolo Pisati <paolo.pisati@canonical.com>
Thu, 10 Feb 2022 14:31:37 +0000 (15:31 +0100)
commit0ca0f1fb7353a9a6f4458d04c75b3ef258ba41d0
tree6486b3b3632d1bae0059907a306fdf2318dd2ce4
parent2304d5ca2a64353ba95331d5994d002b96987722
gpio: idt3243x: Fix an ignored error return from platform_get_irq()

BugLink: https://bugs.launchpad.net/bugs/1960516
commit 7c1cf55577782725ea2bc24687767c8fe8e57486 upstream.

The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'parent_irq', so making 'parent_irq' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-idt3243x.c:167:6-16: WARNING: Unsigned expression
compared with zero: parent_irq < 0

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: 30fee1d7462a ("gpio: idt3243x: Fix IRQ check in idt_gpio_probe")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/gpio/gpio-idt3243x.c