]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: macb: Fix runtime PM refcounting
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 27 Apr 2020 10:51:20 +0000 (13:51 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 May 2020 03:27:48 +0000 (20:27 -0700)
commit0ce205d4660c312cdeb4a81066616dcc6f3799c4
treec609b09b68e2fe3ec7e492bdb969a1a6a68810a6
parentee8d2267f0e39a1bfd95532da3a6405004114b27
net: macb: Fix runtime PM refcounting

The commit e6a41c23df0d, while trying to fix an issue,

    ("net: macb: ensure interface is not suspended on at91rm9200")

introduced a refcounting regression, because in error case refcounter
must be balanced. Fix it by calling pm_runtime_put_noidle() in error case.

While here, fix the same mistake in other couple of places.

Fixes: e6a41c23df0d ("net: macb: ensure interface is not suspended on at91rm9200")
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb_main.c