]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
nbd: fix possible overflow on 'first_minor' in nbd_dev_add()
authorZhang Wensheng <zhangwensheng5@huawei.com>
Thu, 10 Mar 2022 09:32:24 +0000 (17:32 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 12:40:29 +0000 (14:40 +0200)
commit0cee5e0d5dc70166832435c25e1007aa42d3a4dd
treec694caf9ad17e2618487aca4d4dfd9e23b730552
parent34b6f794d08776a7fbabb2050425d35c744f5bbc
nbd: fix possible overflow on 'first_minor' in nbd_dev_add()

BugLink: https://bugs.launchpad.net/bugs/1969107
[ Upstream commit 6d35d04a9e18990040e87d2bbf72689252669d54 ]

When 'index' is a big numbers, it may become negative which forced
to 'int'. then 'index << part_shift' might overflow to a positive
value that is not greater than '0xfffff', then sysfs might complains
about duplicate creation. Because of this, move the 'index' judgment
to the front will fix it and be better.

Fixes: b0d9111a2d53 ("nbd: use an idr to keep track of nbd devices")
Fixes: 940c264984fd ("nbd: fix possible overflow for 'first_minor' in nbd_dev_add()")
Signed-off-by: Zhang Wensheng <zhangwensheng5@huawei.com>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Link: https://lore.kernel.org/r/20220310093224.4002895-1-zhangwensheng5@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit 5142720dbe51befeb25f204f912ef1ad93fba343)
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/block/nbd.c