]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()
authorNathan Chancellor <nathan@kernel.org>
Thu, 17 Jun 2021 06:31:23 +0000 (23:31 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 19 Jun 2021 03:01:04 +0000 (23:01 -0400)
commit0d7be7a8a0090b1c3b982c2b1a944d0d5cad7b39
tree63d70516c70e0966e052d807ae7fb09c5b8ae335
parenta25503617834920e772b9abda608d902dbf26b5c
scsi: elx: efct: Eliminate unnecessary boolean check in efct_hw_command_cancel()

clang warns:

drivers/scsi/elx/efct/efct_hw.c:1523:17: warning: address of array
'ctx->buf' will always evaluate to 'true' [-Wpointer-bool-conversion]
                              (!ctx->buf ? U32_MAX : *((u32 *)ctx->buf)));
                               ~~~~~~^~~

buf is an array in the middle of a struct so deferencing it is not a
problem as long as ctx is not NULL. Eliminate the check, which fixes the
warning.

Link: https://github.com/ClangBuiltLinux/linux/issues/1398
Link: https://lore.kernel.org/r/20210617063123.21239-1-nathan@kernel.org
Fixes: 580c0255e4ef ("scsi: elx: efct: RQ buffer, memory pool allocation and deallocation APIs")
Reviewed-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/elx/efct/efct_hw.c