]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ide-tape: remove back-to-back REQUEST_SENSE detection
authorTejun Heo <tj@kernel.org>
Sat, 18 Apr 2009 22:00:41 +0000 (07:00 +0900)
committerJens Axboe <jens.axboe@oracle.com>
Tue, 28 Apr 2009 05:37:28 +0000 (07:37 +0200)
commit0de57fb93b1daaeaecb658a98b3299ae460c02e9
tree619690c0244902c9d7879a309298b5ae20cfe2af
parent924cec7789f65ab7f022256f6533ecba0747b5f3
ide-tape: remove back-to-back REQUEST_SENSE detection

Impact: fix an oops which always triggers

ide_tape_issue_pc() assumed drive->pc isn't NULL on invocation when
checking for back-to-back request sense issues but drive->pc can be
NULL and even when it's not NULL, it's not safe to dereference it once
the previous command is complete because pc could have been freed or
was on stack.  Kill back-to-back REQUEST_SENSE detection.

Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ide/ide-tape.c