]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
libata: cosmetic clean up in ata_eh_reset()
authorTejun Heo <htejun@gmail.com>
Wed, 24 Oct 2007 06:21:26 +0000 (15:21 +0900)
committerJeff Garzik <jeff@garzik.org>
Thu, 25 Oct 2007 06:02:02 +0000 (02:02 -0400)
commit0e06d9ce7a49d2ef2858cf07b44a324fc3a4c192
treec5dba8cb1a58aa6f002f19bf56aca53db64320dc
parent741b776335c3e91b0b8bf765a97f9484a3cd5034
libata: cosmetic clean up in ata_eh_reset()

Local variable @action usage in ata_eh_reset() is a bit confusing.
It's used only to cache ehc->i.action to test reset masks after
clearing it; however, due to the generic name "action", it's easy to
misinterpret the local variable as containing the selected reset
method later.  Also, the reason for caching the original value is easy
to miss.

This patch renames @action to @tmp_action and make it buffer newly
selected value instead to improve readability.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-eh.c