]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
projects / mirror_ubuntu-disco-kernel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 62d98c9) | patch
NFSv4: Remove BUG_ON() and ACCESS_ONCE() calls in the idmapper
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 28 Sep 2012 16:03:09 +0000 (12:03 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 28 Sep 2012 16:27:11 +0000 (12:27 -0400)
commit0e24d849c4ea777c59955b241fd3af14a1b84af5
tree040025f1f7439395233591cdece544708e8ec333tree
parent62d98c935456ee121b03d6a68aa3091a04085b7ecommit | diff
NFSv4: Remove BUG_ON() and ACCESS_ONCE() calls in the idmapper

The use of ACCESS_ONCE() is wrong, since the various routines that set/clear
idmap->idmap_key_cons should be strictly ordered w.r.t. each other, and
the idmap->idmap_mutex ensures that only one thread at a time may be in
an upcall situation.

Also replace the BUG_ON()s with WARN_ON_ONCE() where appropriate.

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/idmap.c diff | blob | blame | history
Ubuntu Disco kernel mirror for Proxmox VE and PMG