]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/mlx5: DR, Prefer kcalloc over open coded arithmetic
authorLen Baker <len.baker@gmx.com>
Sun, 5 Sep 2021 07:49:36 +0000 (09:49 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Sat, 16 Oct 2021 00:37:46 +0000 (17:37 -0700)
commit0e6f3ef469bbf69ea6840aa4d15dcfc8ce978760
tree399ee59e17a0e823da3b69e04534183c5c55e85b
parent0885ae1a9d34d946e12c1cf9834463ee3541a63a
net/mlx5: DR, Prefer kcalloc over open coded arithmetic

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, refactor the code a bit to use the purpose specific kcalloc()
function instead of the argument size * count in the kzalloc() function.

[1] https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

Signed-off-by: Len Baker <len.baker@gmx.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c