]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
gpio: GPIO_GET_CHIPINFO_IOCTL: Fix information leak
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 18 Oct 2016 14:54:00 +0000 (16:54 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 21 Oct 2016 12:38:02 +0000 (14:38 +0200)
commit0f4bbb233743bdfd51d47688b0bc2561f310488b
tree81da4136ccd901439b0f3ed777a7f2c1a520cd81
parent1f1cc4566bd9dd8d3cf19965a4b6392143618536
gpio: GPIO_GET_CHIPINFO_IOCTL: Fix information leak

The GPIO_GET_CHIPINFO_IOCTL handler allocates a gpiochip_info struct on the
stack and then passes it to copy_to_user(). But depending on the length of
the GPIO chip name and label the struct is only partially initialized.

This exposes the previous, potentially sensitive, stack content to the
issuing userspace application. To avoid this make sure that the struct is
fully initialized.

Cc: stable@vger.kernel.org
Fixes: 521a2ad6f862 ("gpio: add userspace ABI for GPIO line information")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib.c