]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ALSA: i2c/cs8427: Fix int to char conversion
authorPhilipp Klocke <philipp97kl@gmail.com>
Thu, 18 Oct 2018 10:33:02 +0000 (12:33 +0200)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:20:51 +0000 (14:20 -0300)
commit0f591c3c04af8d8ab9e6c0c9d1462adc95043a5d
tree57df70048c5342383084d1350ab4adbccc97f147
parent78810f45150de1dea8dd3f671fb8ccc9b640ed76
ALSA: i2c/cs8427: Fix int to char conversion

BugLink: https://bugs.launchpad.net/bugs/1854975
[ Upstream commit eb7ebfa3c1989aa8e59d5e68ab3cddd7df1bfb27 ]

Compiling with clang yields the following warning:

sound/i2c/cs8427.c:140:31: warning: implicit conversion from 'int'
to 'char' changes value from 160 to -96 [-Wconstant-conversion]
    data[0] = CS8427_REG_AUTOINC | CS8427_REG_CORU_DATABUF;
            ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~

Because CS8427_REG_AUTOINC is defined as 128, it is too big for a
char field.
So change data from char to unsigned char, that it can hold the value.

This patch does not change the generated code.

Signed-off-by: Philipp Klocke <philipp97kl@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
sound/i2c/cs8427.c