]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
Staging: iio: ad7816: constify attribute_group structures
authorBhumika Goyal <bhumirks@gmail.com>
Sat, 1 Oct 2016 19:15:13 +0000 (00:45 +0530)
committerJonathan Cameron <jic23@kernel.org>
Mon, 3 Oct 2016 20:06:04 +0000 (21:06 +0100)
commit0fa90023f23ced839cde3bcc0be4e06b3fc34895
treec62e8d13c5bac582067556d0109b88c550606c3a
parente0e1bec8550114b0571f3867bb355f79b464b1d4
Staging: iio: ad7816: constify attribute_group structures

Check for attribute_group structures that are only stored in the
event_attrs filed of iio_info structure. As the event_attrs field
of iio_info structures is constant, so these attribute_group
structures can also be declared constant.
Done using coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct attribute_group i@p = {...};

@ok1@
identifier r1.i;
position p;
struct iio_info x;
@@
x.event_attrs=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct attribute_group i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct attribute_group i;

File size before:
   text    data     bss     dec     hex filename
   3295     768       0    4063     fdf drivers/staging/iio/adc/ad7816.o

File size after:
   text    data     bss     dec     hex filename
   3359     736       0    4095     fff drivers/staging/iio/adc/ad7816.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/staging/iio/adc/ad7816.c