]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pinctrl: samsung: Fix device node refcount leaks in S3C64xx wakeup controller init
authorKrzysztof Kozlowski <krzk@kernel.org>
Mon, 5 Aug 2019 16:27:09 +0000 (18:27 +0200)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:45 +0000 (14:22 -0300)
commit0fc0c8375d7bed4b99db08de4ae2d7b4eea23a85
treeb10def19ad07b5a8f1fa555c850cf3cd8b53a02f
parent7a75145ff005b1e1477e1a2eaa0f63e75a3f6bf6
pinctrl: samsung: Fix device node refcount leaks in S3C64xx wakeup controller init

BugLink: https://bugs.launchpad.net/bugs/1857158
commit 7f028caadf6c37580d0f59c6c094ed09afc04062 upstream.

In s3c64xx_eint_eint0_init() the for_each_child_of_node() loop is used
with a break to find a matching child node.  Although each iteration of
for_each_child_of_node puts the previous node, but early exit from loop
misses it.  This leads to leak of device node.

Cc: <stable@vger.kernel.org>
Fixes: 61dd72613177 ("pinctrl: Add pinctrl-s3c64xx driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/pinctrl/samsung/pinctrl-s3c64xx.c