]> git.proxmox.com Git - mirror_qemu.git/commit
qmp: Drop duplicated QMP command object checks
authorMarkus Armbruster <armbru@redhat.com>
Fri, 3 Mar 2017 12:32:28 +0000 (13:32 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Sun, 5 Mar 2017 08:14:19 +0000 (09:14 +0100)
commit104fc3027960dd2aa9d310936a6cb201c60e1088
tree28a6fa71d34cda7abd7bb75c9ab0750e4d5f0f66
parent635db18f68ded6abec11cd4cf64ebc15c1c6b190
qmp: Drop duplicated QMP command object checks

qmp_check_input_obj() duplicates qmp_dispatch_check_obj(), except the
latter screws up an error message.  handle_qmp_command() runs first
the former, then the latter via qmp_dispatch(), masking the screwup.

qemu-ga also masks the screwup, because it also duplicates checks,
just differently.

qmp_check_input_obj() exists because handle_qmp_command() needs to
examine the command before dispatching it.  The previous commit got
rid of this need, except for a tracepoint, and a bit of "id" code that
relies on qdict not being null.

Fix up the error message in qmp_dispatch_check_obj(), drop
qmp_check_input_obj() and the tracepoint.  Protect the "id" code with
a conditional.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <1488544368-30622-9-git-send-email-armbru@redhat.com>
monitor.c
qapi/qmp-dispatch.c
trace-events