]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
geneve: Fix races between socket add and release.
authorJesse Gross <jesse@nicira.com>
Wed, 17 Dec 2014 02:25:32 +0000 (18:25 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 Dec 2014 17:38:13 +0000 (12:38 -0500)
commit12069401d895ff84076a50189ca842c0696b84b2
treed93c1ec4635a9d2d64fff54d376e40da3a72e13e
parent7ed767f73192d6daf673c6d885cd02d5f280ac1f
geneve: Fix races between socket add and release.

Currently, searching for a socket to add a reference to is not
synchronized with deletion of sockets. This can result in use
after free if there is another operation that is removing a
socket at the same time. Solving this requires both holding the
appropriate lock and checking the refcount to ensure that it
has not already hit zero.

Inspired by a related (but not exactly the same) issue in the
VXLAN driver.

Fixes: 0b5e8b8e ("net: Add Geneve tunneling protocol driver")
CC: Andy Zhou <azhou@nicira.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/geneve.c