]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drivers/perf: arm_pmu: Fix reference count of a device_node in of_pmu_irq_cfg
authorJulien Grall <julien.grall@arm.com>
Tue, 31 May 2016 11:41:21 +0000 (12:41 +0100)
committerWill Deacon <will.deacon@arm.com>
Fri, 3 Jun 2016 09:16:20 +0000 (10:16 +0100)
commit121323ae668e456d0ed328f5b77c22bf5dd8e4de
treeff3fc3754aedd477965bdf84b8ad1e6017da77e5
parent8051f4d16ef1d037e7b12abab79c3e0b960f4d36
drivers/perf: arm_pmu: Fix reference count of a device_node in of_pmu_irq_cfg

The only function called by of_pmu_irq_cfg that will increment the
reference count on dn is of_parse_phandle.

Each time we successfully parse a possible CPU from an
interrupt-affinity property, we increment the refcount of that CPU node
once via of_parse_handle. After validating the CPU is possible, we
decrement the refcount once. Subsequently, we decrement the refcount
again, either as part of an early break if we don't have a matching SPI,
or as part of the end of the loop body.

This will lead to decrementing twice the refcounnt.
Remove the second pairs of call to of_node_put as nobody is using dn
between the first and second call to of_node_put.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
drivers/perf/arm_pmu.c