]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
gso: validate gso_type in GSO handlers
authorWillem de Bruijn <willemb@google.com>
Fri, 19 Jan 2018 14:29:18 +0000 (09:29 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Jan 2018 21:01:30 +0000 (16:01 -0500)
commit121d57af308d0cf943f08f4738d24d3966c38cd9
tree6089dfcad08b4d02fe8e8082f2d278a5cbec05a3
parent7c68d1a6b4db9012790af7ac0f0fdc0d2083422a
gso: validate gso_type in GSO handlers

Validate gso_type during segmentation as SKB_GSO_DODGY sources
may pass packets where the gso_type does not match the contents.

Syzkaller was able to enter the SCTP gso handler with a packet of
gso_type SKB_GSO_TCPV4.

On entry of transport layer gso handlers, verify that the gso_type
matches the transport protocol.

Fixes: 90017accff61 ("sctp: Add GSO support")
Link: http://lkml.kernel.org/r/<001a1137452496ffc305617e5fe0@google.com>
Reported-by: syzbot+fee64147a25aecd48055@syzkaller.appspotmail.com
Signed-off-by: Willem de Bruijn <willemb@google.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/esp4_offload.c
net/ipv4/tcp_offload.c
net/ipv4/udp_offload.c
net/ipv6/esp6_offload.c
net/ipv6/tcpv6_offload.c
net/ipv6/udp_offload.c
net/sctp/offload.c