]> git.proxmox.com Git - mirror_qemu.git/commit
qapi: Inline gen_visit_members() into lone caller
authorEric Blake <eblake@redhat.com>
Thu, 17 Mar 2016 22:48:35 +0000 (16:48 -0600)
committerMarkus Armbruster <armbru@redhat.com>
Fri, 18 Mar 2016 09:29:26 +0000 (10:29 +0100)
commit12f254fd5f98717d17f079c73500123303b232da
tree693e7f62d5834bc045e6067a334e7452b5fdfea7
parentc1ff0e6c853111496a3c5ae392b9adae5043c7be
qapi: Inline gen_visit_members() into lone caller

Commit 82ca8e46 noticed that we had multiple implementations of
visiting every member of a struct, and consolidated it into
gen_visit_fields() (now gen_visit_members()) with enough
parameters to cater to slight differences between the clients.
But recent exposure of implicit types has meant that we are now
down to a single use of that method, so we can clean up the
unused conditionals and just inline it into the remaining
caller: gen_visit_object_members().

Likewise, gen_err_check() no longer needs optional parameters,
as the lone use of non-defaults was via gen_visit_members().

No change to generated code.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1458254921-17042-11-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
scripts/qapi-visit.py
scripts/qapi.py