]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
tmpfs: fix regression hang in fallocate undo
authorHugh Dickins <hughd@google.com>
Sun, 10 Jul 2016 23:46:32 +0000 (16:46 -0700)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 9 Aug 2016 13:09:10 +0000 (15:09 +0200)
commit130291915a171b18b8db162d0e14819f18673589
tree80ae9dfbc8383908e1305b4cb23384e1f3d12994
parentaeb2daadf2a79bece924a4fb99aedf004f1e17df
tmpfs: fix regression hang in fallocate undo

BugLink: http://bugs.launchpad.net/bugs/1607404
commit 7f556567036cb7f89aabe2f0954b08566b4efb53 upstream.

The well-spotted fallocate undo fix is good in most cases, but not when
fallocate failed on the very first page.  index 0 then passes lend -1
to shmem_undo_range(), and that has two bad effects: (a) that it will
undo every fallocation throughout the file, unrestricted by the current
range; but more importantly (b) it can cause the undo to hang, because
lend -1 is treated as truncation, which makes it keep on retrying until
every page has gone, but those already fully instantiated will never go
away.  Big thank you to xfstests generic/269 which demonstrates this.

Fixes: b9b4bb26af01 ("tmpfs: don't undo fallocate past its last page")
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
mm/shmem.c