]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/amd/display: Fix warning in disabling vblank irq
authorAlan Liu <haoping.liu@amd.com>
Tue, 2 May 2023 09:54:50 +0000 (17:54 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 24 May 2023 20:20:36 +0000 (16:20 -0400)
commit137f9cee113df91107cf91c130d5c414c4b191f0
tree17abd1f628c6959d3ede03705802796cb3743148
parent40baba5693b9af586dc1063af603d05a79e57a6b
drm/amd/display: Fix warning in disabling vblank irq

[Why]
During gpu-reset, we toggle vblank irq by calling dc_interrupt_set()
instead of amdgpu_irq_get/put() because we don't want to change the irq
source's refcount. However, we see the warning when vblank irq is enabled
by dc_interrupt_set() during gpu-reset but disabled by amdgpu_irq_put()
after gpu-reset.

[How]
Only in dm_gpureset_toggle_interrupts() we toggle vblank interrupts by
calling dc_interrupt_set(). Apart from this we call dm_set_vblank()
which uses amdgpu_irq_get/put() to operate vblank irq.

Reviewed-by: Bhawanpreet Lakha <bhawanpreet.lakha@amd.com>
Acked-by: Tom Chung <chiahsuan.chung@amd.com>
Signed-off-by: Alan Liu <haoping.liu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c