]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
can: ems_usb: ems_usb_start_xmit(): fix double dev_kfree_skb() in error path
authorHangyu Hua <hbh25y@gmail.com>
Tue, 19 Apr 2022 12:44:20 +0000 (09:44 -0300)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 20 May 2022 13:17:07 +0000 (15:17 +0200)
commit13bcba6a76b40e39ed753fd17e1548f7798e186b
tree98f33e056018ef51841e5abd8e0eba7918e698bd
parent4198c3f3e348fb4cb5eb165396b08d457fd659ab
can: ems_usb: ems_usb_start_xmit(): fix double dev_kfree_skb() in error path

There is no need to call dev_kfree_skb() when usb_submit_urb() fails
beacause can_put_echo_skb() deletes the original skb and
can_free_echo_skb() deletes the cloned skb.

Link: https://lore.kernel.org/all/20220228083639.38183-1-hbh25y@gmail.com
Fixes: 702171adeed3 ("ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface")
Cc: stable@vger.kernel.org
Cc: Sebastian Haas <haas@ems-wuensche.com>
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
CVE-2022-28390
(cherry picked from commit c70222752228a62135cee3409dccefd494a24646)
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/can/usb/ems_usb.c